RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v3]
Erik Joelsson
erikj at openjdk.org
Thu Dec 1 14:12:06 UTC 2022
On Wed, 30 Nov 2022 23:23:30 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> implemented case 5
>
> vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1664:
>
>> 1662:
>> 1663: @Override
>> 1664: public Optional<Hash> wholeHash(String rev) {
>
> Isn't this just `::resolve(String)`?
What I mean is, you could use resolve instead of introducing this new method.
-------------
PR: https://git.openjdk.org/skara/pull/1428
More information about the skara-dev
mailing list