RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v3]

Zhao Song zsong at openjdk.org
Thu Dec 1 16:27:50 UTC 2022

On Thu, 1 Dec 2022 14:08:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1664:
>>> 1662: 
>>> 1663:     @Override
>>> 1664:     public Optional<Hash> wholeHash(String rev) {
>> Isn't this just `::resolve(String)`?
> What I mean is, you could use resolve instead of introducing this new method.

Oh, I don't know why I didn't see some of your review yesterday. Ah, right, I will use resolve and delete the new method


PR: https://git.openjdk.org/skara/pull/1428

More information about the skara-dev mailing list