RFR: 1707: Bot warns about "No .jcheck/conf found" when it should not [v2]

Zhao Song zsong at openjdk.org
Mon Dec 5 22:27:40 UTC 2022

> In [SKARA-1393](https://bugs.openjdk.org/browse/SKARA-1393), I added some checks to ensure the target branch of a pr contains valid jcheck configuration. This change went live on November 28, however, some users found that the warning of "No .jcheck/conf found" printed after they integrated their pr. After more investigation, I am thinking it's maybe a GitLab bug. Since when the issue happens, GitLab will always return "Commit Not Found", so we could have a temporary workaround right now.
> For GitLab REST API:
> If commit not found, it will return "404 Commit Not Found"
> If file not found it will return "404 File Not Found"
> For Github REST API:
> If commit not found, it will return "No commit found for the ref "
> If file not found it will return "Not found"

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/LimitedCensusInstance.java
  Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>


  - all: https://git.openjdk.org/skara/pull/1435/files
  - new: https://git.openjdk.org/skara/pull/1435/files/ad691448..f5c68229

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1435&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1435&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1435.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1435/head:pull/1435

PR: https://git.openjdk.org/skara/pull/1435

More information about the skara-dev mailing list