RFR: 1707: Bot warns about "No .jcheck/conf found" when it should not [v2]

Erik Joelsson erikj at openjdk.org
Mon Dec 5 23:04:18 UTC 2022

On Mon, 5 Dec 2022 22:27:40 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-1393](https://bugs.openjdk.org/browse/SKARA-1393), I added some checks to ensure the target branch of a pr contains valid jcheck configuration. This change went live on November 28, however, some users found that the warning of "No .jcheck/conf found" printed after they integrated their pr. After more investigation, I am thinking it's maybe a GitLab bug. Since when the issue happens, GitLab will always return "Commit Not Found", so we could have a temporary workaround right now.
>> For GitLab REST API:
>> If commit not found, it will return "404 Commit Not Found"
>> If file not found it will return "404 File Not Found"
>> For Github REST API:
>> If commit not found, it will return "No commit found for the ref "
>> If file not found it will return "Not found"
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/LimitedCensusInstance.java
>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

Marked as reviewed by erikj (Lead).

I see some tests are failing and it looks related.


PR: https://git.openjdk.org/skara/pull/1435Changes requested by erikj (Lead).

More information about the skara-dev mailing list