Integrated: 1707: Bot warns about "No .jcheck/conf found" when it should not
Zhao Song
zsong at openjdk.org
Tue Dec 6 23:56:23 UTC 2022
On Mon, 5 Dec 2022 21:58:43 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In [SKARA-1393](https://bugs.openjdk.org/browse/SKARA-1393), I added some checks to ensure the target branch of a pr contains valid jcheck configuration. This change went live on November 28, however, some users found that the warning of "No .jcheck/conf found" printed after they integrated their pr. After more investigation, I am thinking it's maybe a GitLab bug. Since when the issue happens, GitLab will always return "Commit Not Found", so we could have a temporary workaround right now.
>
> For GitLab REST API:
> If commit not found, it will return "404 Commit Not Found"
>
> If file not found it will return "404 File Not Found"
>
> For Github REST API:
> If commit not found, it will return "No commit found for the ref "
>
> If file not found it will return "Not Found"
This pull request has now been integrated.
Changeset: 1d7e355c
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/1d7e355c863768214389f64ecfb47193c78964ef
Stats: 95 lines in 16 files changed: 36 ins; 18 del; 41 mod
1707: Bot warns about "No .jcheck/conf found" when it should not
Reviewed-by: erikj, ihse
-------------
PR: https://git.openjdk.org/skara/pull/1435
More information about the skara-dev
mailing list