RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed [v2]

Erik Joelsson erikj at openjdk.org
Thu Dec 8 15:30:52 UTC 2022

On Wed, 7 Dec 2022 23:29:30 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   fix some problems
> vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1731:
>> 1729:                         .anyMatch(diff -> diff.patches().stream()
>> 1730:                                 .anyMatch(patch -> patch.toString().contains(filename))));
>> 1731:     }
> @erikj79 I am not sure I get you correctly. Correct me if I misunderstand what you mean.

I wasn't very clear. I don't think we need this method on GitRepository. I figured we could just inline this at the single call site in CheckRun, but since the expression is quite long, then probably a private method in CheckRun would be best.

You can use `commits(String range)` to just get the single commit we are interested in.


PR: https://git.openjdk.org/skara/pull/1439

More information about the skara-dev mailing list