RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed [v2]

Erik Joelsson erikj at openjdk.org
Thu Dec 8 15:34:21 UTC 2022

On Wed, 7 Dec 2022 23:25:22 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Yeah, pass hash is better. But even if we pass hash here, it won't affect the logic of using confOverride because confOverride is set in the constructor of `CheckablePullRequest`
> Now, I prefer not to change this method because I think ` CheckablePullRequest#targetHash` can help us reuse the target hash. If we add hash as an argument, we will need to call `PullRequestUtils.targetHash(localRepo)` more than once.

`CheckablePullRequest#targetHash` is public so you can call it from `CheckRun`.


PR: https://git.openjdk.org/skara/pull/1439

More information about the skara-dev mailing list