RFR: 1691: Run Jcheck twice in CheckRun if .jcheck/conf has changed [v2]

Zhao Song zsong at openjdk.org
Thu Dec 8 17:47:47 UTC 2022

On Thu, 8 Dec 2022 15:30:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Now, I prefer not to change this method because I think ` CheckablePullRequest#targetHash` can help us reuse the target hash. If we add hash as an argument, we will need to call `PullRequestUtils.targetHash(localRepo)` more than once.
> `CheckablePullRequest#targetHash` is public so you can call it from `CheckRun`.

Oh, then I will change the method. Thanks.


PR: https://git.openjdk.org/skara/pull/1439

More information about the skara-dev mailing list