RFR: 1714: CSR detection only happens on the title bug of a PR

Zhao Song zsong at openjdk.org
Thu Dec 15 18:44:02 UTC 2022

On Thu, 15 Dec 2022 17:44:49 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Currently, our bots only detect CSR issues that are directly linked to the main issue. 
>> With this patch, our bots will be able to detect CSR issues that are linked to all of the issues that this PR solves. Additionally, all detected CSR issues will affect the integration blockers.
>> The `/csr needed` command will allow you to create a CSR issue that is linked to any of the issues solved by this PR. The `/csr unneeded` command will be blocked if any of the issues associated with this PR have an active CSR issue.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 272:
>> 270:         for (var csrIssue : csrIssues) {
>> 271:             if (!csrIssue.isClosed()) {
>> 272:                 ret.put("Change requires a CSR request (" + csrIssue.id() + ") to be approved", false);
> I think we can make the issue IDs links here.

I thought about this too. But then I realized the links can be found under the 'Issues' part in PR body. Do you think we still need the links here? If so, I will add the links.


PR: https://git.openjdk.org/skara/pull/1443

More information about the skara-dev mailing list