RFR: 1714: CSR detection only happens on the title bug of a PR [v3]

Zhao Song zsong at openjdk.org
Fri Dec 16 17:27:23 UTC 2022

On Fri, 16 Dec 2022 13:36:04 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> If we found one approved, we will reply some messages to user and return. What do you think should we do if there is another that is withdrawn? I don't think we need to take any action.
> Say there are two CSRs present already, one approved and one open. If the approved one is found first, then we get the needed marker but no label. If the open one is found first, then we also get the label. This is inconsistent behavior.
> What I think should happen is.
> If there are already CSRs present, then
> 1. if all are approved, just add the needed marker, message could list them and say they are already approved.
> 2. If at least one is open, add both needed marker and label, message should list it and say it needs to be approved. Could also list the approved ones.
> 3. If all are withdrawn, add both needed marker and label, message doesn't need to list them.
> If there are no CSRs present, then
> 4. Add both needed marker and label
> To achieve this you will have to always iterate over all of them and set booleans for each condition, then decide the correct action based on the complete state.

Yes, you are right. I will fix it.


PR: https://git.openjdk.org/skara/pull/1443

More information about the skara-dev mailing list