RFR: 1714: CSR detection only happens on the title bug of a PR [v2]

Zhao Song zsong at openjdk.org
Thu Dec 15 22:31:29 UTC 2022


On Thu, 15 Dec 2022 22:14:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Yes, I think this behavior is right because if we could reach the return statement, it means we already found a non-withdrawn CSR.
>
> But what if there are more? If we find one approved, there may also be another that is withdrawn.

If we found one approved, we will reply some messages to user and return. What do you think should we do if there is another that is withdrawn? I don't think we need to take any action.

>> I thought about this too. But then I realized the links can be found under the 'Issues' part in PR body. Do you think we still need the links here? If so, I will add the links.
>
> I think it would help.

Ok, I will add the links

-------------

PR: https://git.openjdk.org/skara/pull/1443


More information about the skara-dev mailing list