RFR: 1714: CSR detection only happens on the title bug of a PR [v3]

Erik Joelsson erikj at openjdk.org
Fri Dec 16 13:39:34 UTC 2022

On Thu, 15 Dec 2022 22:29:12 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> But what if there are more? If we find one approved, there may also be another that is withdrawn.
> If we found one approved, we will reply some messages to user and return. What do you think should we do if there is another that is withdrawn? I don't think we need to take any action.

Say there are two CSRs present already, one approved and one open. If the approved one is found first, then we get the needed marker but no label. If the open one is found first, then we also get the label. This is inconsistent behavior.

What I think should happen is.

If there are already CSRs present, then
1. if all are approved, just add the needed marker
2. If at least one is open, add both needed marker and label
3. If all are withdrawn, add both needed marker and label

If there are no CSRs present, then
4. Add both needed marker and label

To achieve this you will have to always iterate over all of them and set booleans for each condition, then decide the correct action based on the complete state.


PR: https://git.openjdk.org/skara/pull/1443

More information about the skara-dev mailing list