RFR: 1728: Should iterate over all issues in PullRequestWorkItem in CSR bot

Zhao Song zsong at openjdk.org
Thu Dec 22 19:49:29 UTC 2022

On Thu, 22 Dec 2022 19:34:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> While testing [SKARA-1714](https://bugs.openjdk.org/browse/SKARA-1714) on the staging environment, I discovered a bug in the PullRequestWorkItem in the CSR bot. The issue is that the for loop does not always iterate over all CSR issues for a pull request. 
>> For example, if we have two active CSR issues (csr1 and csr2) for one pull request, and we withdraw csr2, the loop will exit early after iterating over csr1 and CSR_UPDATE_MARKER will not be added, which means the PR body will not be updated and the status change of csr2 will not be displayed. 
>> Also, if we find a withdrawn pr, we need to add CSR_UPDATE_MARKER to the pr body.
> bots/csr/src/test/java/org/openjdk/skara/bots/csr/CSRBotTests.java line 43:
>> 41: class CSRBotTests {
>> 42:     private final static String CSR_UPDATE_MARKER = "<!-- csr: 'update' -->";
>> 43:     private static final String PROGRESS_MARKER = "<!-- Anything below this marker will be automatically updated, please do not edit manually! -->";
> I didn't notice this before, but these markers shouldn't be redefined here in the test. Make them package protected or even public in `PullRequestWorkItem` instead.


Sure, will fix it. Thx!


PR: https://git.openjdk.org/skara/pull/1449

More information about the skara-dev mailing list