RFR: 1728: Should iterate over all issues in PullRequestWorkItem in CSR bot [v2]

Zhao Song zsong at openjdk.org
Thu Dec 22 20:24:42 UTC 2022

> While testing [SKARA-1714](https://bugs.openjdk.org/browse/SKARA-1714) on the staging environment, I discovered a bug in the PullRequestWorkItem in the CSR bot. The issue is that the for loop does not always iterate over all CSR issues for a pull request. 
> For example, if we have two active CSR issues (csr1 and csr2) for one pull request, and we withdraw csr2, the loop will exit early after iterating over csr1 and CSR_UPDATE_MARKER will not be added, which means the PR body will not be updated and the status change of csr2 will not be displayed. 
> Also, if we find a withdrawn pr, we need to add CSR_UPDATE_MARKER to the pr body.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  fix a problem


  - all: https://git.openjdk.org/skara/pull/1449/files
  - new: https://git.openjdk.org/skara/pull/1449/files/fcf90d95..58a9f6ec

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1449&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1449&range=00-01

  Stats: 7 lines in 2 files changed: 2 ins; 3 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1449.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1449/head:pull/1449

PR: https://git.openjdk.org/skara/pull/1449

More information about the skara-dev mailing list