RFR: 1728: Should iterate over all issues in PullRequestWorkItem in CSR bot [v2]

Zhao Song zsong at openjdk.org
Thu Dec 22 20:53:52 UTC 2022


On Thu, 22 Dec 2022 20:45:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix a problem
>
> bots/csr/src/main/java/org/openjdk/skara/bots/csr/PullRequestWorkItem.java line 53:
> 
>> 51:     private final static String CSR_LABEL = "csr";
>> 52:     protected final static String CSR_UPDATE_MARKER = "<!-- csr: 'update' -->";
>> 53:     protected static final String PROGRESS_MARKER = "<!-- Anything below this marker will be automatically updated, please do not edit manually! -->";
> 
> Does this work? I thought you needed to use the default package protected (by removing any `private` or `protected` prefix).

Yes, this works. Ok, I will remove the prefix.

-------------

PR: https://git.openjdk.org/skara/pull/1449


More information about the skara-dev mailing list