RFR: 1728: Should iterate over all issues in PullRequestWorkItem in CSR bot [v2]

Erik Joelsson erikj at openjdk.org
Thu Dec 22 20:47:36 UTC 2022

On Thu, 22 Dec 2022 20:24:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> While testing [SKARA-1714](https://bugs.openjdk.org/browse/SKARA-1714) on the staging environment, I discovered a bug in the PullRequestWorkItem in the CSR bot. The issue is that the for loop does not always iterate over all CSR issues for a pull request. 
>> For example, if we have two active CSR issues (csr1 and csr2) for one pull request, and we withdraw csr2, the loop will exit early after iterating over csr1 and CSR_UPDATE_MARKER will not be added, which means the PR body will not be updated and the status change of csr2 will not be displayed. 
>> Also, if we find a withdrawn pr, we need to add CSR_UPDATE_MARKER to the pr body.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   fix a problem

bots/csr/src/main/java/org/openjdk/skara/bots/csr/PullRequestWorkItem.java line 53:

> 51:     private final static String CSR_LABEL = "csr";
> 52:     protected final static String CSR_UPDATE_MARKER = "<!-- csr: 'update' -->";
> 53:     protected static final String PROGRESS_MARKER = "<!-- Anything below this marker will be automatically updated, please do not edit manually! -->";

Does this work? I thought you needed to use the default package protected (by removing any `private` or `protected` prefix).


PR: https://git.openjdk.org/skara/pull/1449

More information about the skara-dev mailing list