RFR: SKARA-1347: Enable binary check

[Guoxiong Li]

On Wed, 9 Feb 2022 15:11:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Hi all,
>> 
>> The binary check was not effective in the past. This patch fixes it to enable binary check.
>> Thanks for taking the time to reivew.
>> 
>> Best Regards,
>> -- Guoxiong
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 266:
> 
>> 264:     @Override
>> 265:     public void visit(BinaryIssue issue) {
>> 266:         addFailureMessage(issue.check(), "The binary file " + issue.path().toString() + " is not allowed in this repository.");
> 
> Can you make the message match the ones for executable files and symbolic links above?

What about `String.format("Binary files are not allowed (file: %s)", issue.path())`?

-------------

PR: https://git.openjdk.java.net/skara/pull/1283