Integrated: 1298: IssueNotifier removes and re-adds review links and comments

Guoxiong Li gli at openjdk.java.net
Mon Jan 3 14:57:16 UTC 2022


On Sun, 26 Dec 2021 11:21:47 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> When the author of the PR modified the PR body, the Github will store the PR body by using its internal line separator instead of `\n`. The method `parseIssues` can't identify the line separator so that it can't find any issue.
> 
> This patch enhances the pattern to let it identify the `\r` as well and the corresponding test case is added.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: 8aab2a59
Author:    Guoxiong Li <gli at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/8aab2a590929de7d98c8bd1e8c6cf12e40cb6433
Stats:     38 lines in 2 files changed: 37 ins; 0 del; 1 mod

1298: IssueNotifier removes and re-adds review links and comments

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/skara/pull/1269


More information about the skara-dev mailing list