RFR: 1298: IssueNotifier removes and re-adds review links and comments
Guoxiong Li
gli at openjdk.java.net
Mon Jan 3 14:47:32 UTC 2022
On Mon, 3 Jan 2022 14:40:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Hi all,
>>
>> When the author of the PR modified the PR body, the Github will store the PR body by using its internal line separator instead of `\n`. The method `parseIssues` can't identify the line separator so that it can't find any issue.
>>
>> This patch enhances the pattern to let it identify the `\r` as well and the corresponding test case is added.
>>
>> Thanks for taking the time to review.
>>
>> Best Regards,
>> -- Guoxiong
>
> Nice find!
@erikj79 Thanks for the review. Could I get your help to sponsor this patch?
-------------
PR: https://git.openjdk.java.net/skara/pull/1269
More information about the skara-dev
mailing list