RFR: Refactoring in preparation for SKARA-1146 [v2]

Kevin Rushforth kcr at openjdk.java.net
Thu Jan 6 22:38:25 UTC 2022

On Thu, 6 Jan 2022 22:14:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> While working on SKARA-1146, I felt that I needed to do some refactoring. To ease the review process, I've separated those changes into a separate PR. Nothing should change functionally from this change. Here is what I've done:
>> * Created String constants for the special custom fields we have in JBS.
>> * In IssueNotifier, created a method for finding the fixVersion for a branch. This code block is actually copied and sprinkled all over the code base, but for now, I will just unify the copies in the same class.
> Erik Joelsson has updated the pull request incrementally with two additional commits since the last revision:
>  - Rename variable
>  - Remove unwanted change

Marked as reviewed by kcr (Reviewer).


PR: https://git.openjdk.java.net/skara/pull/1270

More information about the skara-dev mailing list