Integrated: Refactoring in preparation for SKARA-1146

Erik Joelsson erikj at openjdk.java.net
Thu Jan 6 23:03:49 UTC 2022


On Mon, 3 Jan 2022 20:59:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> While working on SKARA-1146, I felt that I needed to do some refactoring. To ease the review process, I've separated those changes into a separate PR. Nothing should change functionally from this change. Here is what I've done:
> 
> * Created String constants for the special custom fields we have in JBS.
> * In IssueNotifier, created a method for finding the fixVersion for a branch. This code block is actually copied and sprinkled all over the code base, but for now, I will just unify the copies in the same class.

This pull request has now been integrated.

Changeset: 6ebda450
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/6ebda450ec0adb58dbc60d071d1386622912c9fd
Stats:     108 lines in 10 files changed: 36 ins; 26 del; 46 mod

Refactoring in preparation for SKARA-1146

Reviewed-by: kcr

-------------

PR: https://git.openjdk.java.net/skara/pull/1270


More information about the skara-dev mailing list