RFR: 1308: CSRBot only reacts to approved CSR if PR is touched

Kevin Rushforth kcr at openjdk.java.net
Thu Jan 13 22:25:00 UTC 2022

On Thu, 13 Jan 2022 22:15:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 75:
>>> 73:             if (!cache.needsUpdate(pr)) {
>>> 74:                 continue;
>>> 75:             }
>> An alternative to eliminating this check would be to poll JBS either if the PR was updated or if the PR has a csr label. But as you say, maybe it won't be a performance problem, in which case your proposed change is better.
> Note that we also want to react if a CSR issue is created when the label isn't there. In that case we automatically add the CSR label.

Yeah, that's the main reason your fix is better.


PR: https://git.openjdk.java.net/skara/pull/1274

More information about the skara-dev mailing list