Integrated: 1308: CSRBot only reacts to approved CSR if PR is touched

Erik Joelsson erikj at openjdk.java.net
Fri Jan 14 18:49:25 UTC 2022


On Thu, 13 Jan 2022 21:15:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> When a CSR issue is approved, any associated PR is only updated once someone touches the PR. The CSRBot will not evaluate anything about a PR unless there is a change to the PR. Since a CSR issue update only happens in JBS, the CSRBot cannot be limited by PR updates, it needs to check Jira for changes.
> 
> This patch removes the use of the PullRequestUpdateCache to limit when the bot evaluates a PR. If this turns out to generate too much load on JBS, we will have to implement a limiter in some way, but I don't think it will be a big issue in practice.

This pull request has now been integrated.

Changeset: 677bf943
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/677bf943d78a45c0e561a53109c1fb4de709fd10
Stats:     7 lines in 1 file changed: 0 ins; 7 del; 0 mod

1308: CSRBot only reacts to approved CSR if PR is touched

Reviewed-by: kcr

-------------

PR: https://git.openjdk.java.net/skara/pull/1274


More information about the skara-dev mailing list