RFR: 1329: incorrect hgupdate label for JDK 7 updates

Magnus Ihse Bursie ihse at openjdk.java.net
Thu Jan 27 09:58:17 UTC 2022

On Wed, 26 Jan 2022 20:16:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch adds special handling of Backports for a couple of historic releases where we have 30 or more builds (and no BPRs).

LGTM barring my question about the upper bound for BPRs.

jbs/src/main/java/org/openjdk/skara/jbs/Backports.java line 320:

> 318:                             if (resolvedInBuildNumber < 30) {
> 319:                                 ret.add(jdkVersion.feature());
> 320:                             } else if (resolvedInBuildNumber < 60) {

In the JBS comment you stated that the spec says BPR builds should only be < 39. Did you chose not to change the current formulation, or did you forget?


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1280

More information about the skara-dev mailing list