RFR: 1329: incorrect hgupdate label for JDK 7 updates

Erik Joelsson erikj at openjdk.java.net
Thu Jan 27 14:49:35 UTC 2022

On Thu, 27 Jan 2022 09:55:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This patch adds special handling of Backports for a couple of historic releases where we have 30 or more builds (and no BPRs).
> jbs/src/main/java/org/openjdk/skara/jbs/Backports.java line 320:
>> 318:                             if (resolvedInBuildNumber < 30) {
>> 319:                                 ret.add(jdkVersion.feature());
>> 320:                             } else if (resolvedInBuildNumber < 60) {
> In the JBS comment you stated that the spec says BPR builds should only be < 39. Did you chose not to change the current formulation, or did you forget?

I initially changed this to 40, as the specification we have says BPR between 30 and 39. The problem is that this leaves a gap between 40 and 59 which is undefined. Builds 60 and up are special and should never be considered for hgupdate-sync, but after contemplating this, I agree with the original author's conclusion that the best way to deal with 40-59 is to assume they are also BPRs. In reality, I don't think we have any release with builds in that range, so it doesn't actually matter.


PR: https://git.openjdk.java.net/skara/pull/1280

More information about the skara-dev mailing list