RFR: 1495: /backport should be allowed in PRs which have been integrated [v2]

Guoxiong Li gli at openjdk.org
Thu Jul 28 22:47:00 UTC 2022

On Thu, 28 Jul 2022 19:42:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> What about adding a parameter like `Pattern commitComment` to the method `findIntegratedCommitHash`?
> The drawback of that is that we then need to have a copy of the pattern everywhere we call the method. I think it's better to have something like a static method on PullRequest like `String commitHashMessage(Hash)`, which takes a hash and returns a String with the formatted message. IntegrateCommand can use that to format the relevant part of the comment.

Maybe someone has another more elegant way to solve this issue. But now I can't find such way, so it is good to adopt your idea now.


PR: https://git.openjdk.org/skara/pull/1341

More information about the skara-dev mailing list