RFR: 1495: /backport should be allowed in PRs which have been integrated [v2]

[Erik Joelsson]

On Thu, 28 Jul 2022 13:05:11 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandExtractor.java line 55:
>> 
>>> 53:                 }
>>> 54:                 var command = commandMatcher.group(1).toLowerCase();
>>> 55:                 var handler = commitCommandFirst ? CommitCommandWorkItem.commandHandlers.get(command) : PullRequestCommandWorkItem.commandHandlers.get(command);
>> 
>> What are you trying to achieve with the commitCommandFirst boolean? In what situation would it be wrong to just use one unified list?
>
>>  In what situation would it be wrong to just use one unified list?
> 
> The only one situation I concern about is the `help` command. But after second thought, it looks good. So I unified them.

Hm, now I realize what you mean about the HelpCommand. If you invoke `/help` on a commit now, you get all the PR commands listed. That's not good. We still need some way of separating which commands should be listed for help with a commit and help with a PR.

-------------

PR: https://git.openjdk.org/skara/pull/1341