RFR: 1433: The change of the CSR status doesn't force the CheckWorkItem to re-run the check [v2]
Guoxiong Li
gli at openjdk.java.net
Wed Jun 1 09:42:17 UTC 2022
On Tue, 31 May 2022 17:58:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Only check the Skara generated part. Adjust log. Avoid adding marker multiple times.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java line 37:
>
>> 35: private static final String CSR_LABEL = "csr";
>> 36: private static final String CSR_NEEDED_MARKER = "<!-- csr: 'needed' -->";
>> 37: private static final String CSR_UNNEEDED_MARKER = "<!-- csr: 'unneeded' -->";
>
> Did you intend to look for this in the CSRBot?
> (optionally) use command /csr needed again
> (optionally) then the CheckWorkItem also doesn't re-run the check
Sometimes the developers may use the `/csr` command again. I would like to let the CheckWorkItem re-run the check immediately instead of waiting for JEPBot, which may reduce about 10 minutes.
-------------
PR: https://git.openjdk.java.net/skara/pull/1327
More information about the skara-dev
mailing list