RFR: 1433: The change of the CSR status doesn't force the CheckWorkItem to re-run the check [v2]
Erik Joelsson
erikj at openjdk.java.net
Mon Jun 6 09:16:18 UTC 2022
On Mon, 6 Jun 2022 08:23:26 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> I don't understand what you mean. You set these markers, but I don't see anything looking for them.
>
> // file CheckWorkItem.java
> - private final Pattern metadataComments = Pattern.compile("<!-- (?:(add|remove) (?:contributor|reviewer))|(?:summary: ')|(?:solves: ')|(?:additional required reviewers)|(?:jep: ')");
> + private final Pattern metadataComments = Pattern.compile("<!-- (?:(add|remove) (?:contributor|reviewer))|(?:summary: ')|(?:solves: ')|(?:additional required reviewers)|(?:jep: ')|(?:csr: ')");
>
>
> The newly added `(?:csr: ')` of the `metadataComments` can search it and update the metadata so that the check can be re-run.
Ah of course, thanks.
-------------
PR: https://git.openjdk.java.net/skara/pull/1327
More information about the skara-dev
mailing list