RFR: 1432: The command `/csr unneeded` doesn't correctly handle an approved CSR

Guoxiong Li gli at openjdk.java.net
Tue Jun 7 15:31:31 UTC 2022

On Tue, 7 Jun 2022 11:54:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Hi all,
>> Currently, when using the command `/csr unneeded` and the PR doesn't have `csr` label, the `CSRCommand` can't distinguish the situations of having no csr request and having an approved csr request. This patch removes the conditional statement `labels.contains(CSR_LABEL)` of the method `CSRCommand::handle` so that its following code can distinguish the different situations and reply different messages.
>> And the code about removing `csr` label is moved to the method `csrUnneededReply` to reduce some duplication.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Looks good to me.

@magicus @erikj79 Thanks for the review. Integrating.


PR: https://git.openjdk.java.net/skara/pull/1331

More information about the skara-dev mailing list