Integrated: 1432: The command `/csr unneeded` doesn't correctly handle an approved CSR

[Guoxiong Li]

On Tue, 7 Jun 2022 11:26:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> Currently, when using the command `/csr unneeded` and the PR doesn't have `csr` label, the `CSRCommand` can't distinguish the situations of having no csr request and having an approved csr request. This patch removes the conditional statement `labels.contains(CSR_LABEL)` of the method `CSRCommand::handle` so that its following code can distinguish the different situations and reply different messages.
> 
> And the code about removing `csr` label is moved to the method `csrUnneededReply` to reduce some duplication.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: 46b0e597
Author:    Guoxiong Li <gli at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/46b0e597c478d28c3c8eec2baf7bc5c91d0e1bba
Stats:     29 lines in 2 files changed: 10 ins; 11 del; 8 mod

1432: The command `/csr unneeded` doesn't correctly handle an approved CSR

Reviewed-by: ihse, erikj

-------------

PR: https://git.openjdk.java.net/skara/pull/1331