RFR: 1478: Add metrics and loggin measuring time before WorkItems start to run [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Jun 14 16:37:24 UTC 2022

On Tue, 14 Jun 2022 14:12:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> In order to investigate and assess performance issues with the Skara bots, I need more data. One key class of data I'm missing is the time it takes from when a WorkItem is created or submitted to when it actually starts to run. This patch adds both metric gauges and log messages that include this information.
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>   Added comment

bot/src/main/java/org/openjdk/skara/bot/BotRunner.java line 223:

> 221:                     "work_id", String.valueOf(workId)))) {
> 222:                 var submittedDuration = Duration.between(createTime, Instant.now());
> 223:                 SUBMITTED_TIME_GAUGE.labels(item.botName(), item.workItemName()).set(submittedDuration.toMillis() / 1_000_000.0);

"to millis" and "divide by a million" looks a bit sus. Can you confirm that you're getting the units right?


PR: https://git.openjdk.org/skara/pull/1337

More information about the skara-dev mailing list