RFR: 1478: Add metrics and loggin measuring time before WorkItems start to run [v2]

Erik Joelsson erikj at openjdk.java.net
Wed Jun 15 11:09:53 UTC 2022


On Tue, 14 Jun 2022 16:34:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added comment
>
> bot/src/main/java/org/openjdk/skara/bot/BotRunner.java line 223:
> 
>> 221:                     "work_id", String.valueOf(workId)))) {
>> 222:                 var submittedDuration = Duration.between(createTime, Instant.now());
>> 223:                 SUBMITTED_TIME_GAUGE.labels(item.botName(), item.workItemName()).set(submittedDuration.toMillis() / 1_000_000.0);
> 
> "to millis" and "divide by a million" looks a bit sus. Can you confirm that you're getting the units right?

You are right, that's a mistake.

-------------

PR: https://git.openjdk.org/skara/pull/1337


More information about the skara-dev mailing list