RFR: 1422: Remove the need to type `JEP-` or `jep-` prefix in `jep` command
Erik Joelsson
erikj at openjdk.java.net
Tue May 3 12:54:27 UTC 2022
On Tue, 3 May 2022 12:45:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Hi all,
>>
>> This patch permits the strange grammer like `/jep jEP-123` and removes the need of the `JEP-` or `jep-` prefix.
>> When the prefix (`JDK-`, `JEP-` or others) is not provided, the bot treats it as a JEP ID firstly.
>> If the issue is not found, the bot then treats it as an issue ID.
>>
>> Thanks for taking the time to review.
>>
>> Best Regards,
>> -- Guoxiong
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 83:
>
>> 81: jbsIssue = bot.issueProject().jepIssue(args);
>> 82: if (jbsIssue.isEmpty()) {
>> 83: reply.println("The JEP issue of the JEP argument `" + args + "` was not found. " +
>
> Do we really need to print a message about this?
I also noted that on line 150 and 156, the message doesn't start with a capital letter. Could you fix that too?
-------------
PR: https://git.openjdk.java.net/skara/pull/1311
More information about the skara-dev
mailing list