RFR: 1422: Remove the need to type `JEP-` or `jep-` prefix in `jep` command [v2]

Guoxiong Li gli at openjdk.java.net
Tue May 3 14:22:04 UTC 2022


On Tue, 3 May 2022 12:32:14 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some comments/messages. Adjust some test cases.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 58:
> 
>> 56:                  * `/jep jep-123`
>> 57:                  * `/jep JEP-123`
>> 58:                  * `/jep 123`
> 
> I would suggest putting this example first.
> 
> Also, there is an empty line after "Some examples:" but not after "Command syntax:". That looks weird.

Fixed.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/JEPCommand.java line 65:
> 
>> 63:                 The bot firstly treats the ID without prefix as a JEP ID.
>> 64:                 If not found, the bot then treats the ID without prefix as an issue ID.
>> 65:                 The issue type in any case must be `JEP`.
> 
> Suggestion:
> 
>                 The prefix (i.e. `JDK-`, `JEP-` or `jep-`) is optional. If the argument is given without prefix, it will be tried first as a JEP ID and second as an issue ID. The issue type must be `JEP`.
> 
> 
> A text block here is good for formatting the syntax and examples, but text should not be forcibly line broken. Consider adding the text paragraph as an additional string so that it may be broken up in code, but not when posted.

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1311


More information about the skara-dev mailing list