RFR: 1422: Remove the need to type `JEP-` or `jep-` prefix in `jep` command [v3]

Guoxiong Li gli at openjdk.java.net
Wed May 4 05:32:34 UTC 2022


On Tue, 3 May 2022 20:07:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>>> I also noted that on line 150 and 156, the message doesn't start with a capital letter. Could you fix that too?
>> 
>> Fixed.
>> 
>>> Do we really need to print a message about this?
>> 
>> If we don't print such message, when typing `/jep 123` mistakenly (assume the right JEP id is `132` and the issue-123 exists and is not a jep issue), the bot prints `The issue 123 is not a JEP. Please make sure you have entered it correctly`. It may confused the user because the user may think the `123` is a JEP ID instead of a issue ID. And the user may asked why the document said it would firstly be tried as a JEP ID but actually not?
>
> I think that will be clear enough without this extra message.

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1311


More information about the skara-dev mailing list