RFR: 282: Make the review requirements more explicit in the progress list [v3]

[Guoxiong Li]

On Wed, 11 May 2022 13:37:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Actually, it's quite common to have as a requirement 2 reviewers, at least one of which must be a Reviewer and the other an Author (i.e., any role in the Project). Both `jdk` and `jfx` are configured this way. Here is the current Progress item that Skara adds in response to the command `/reviewers 2`:
>> 
>> 
>> - [ ] Change must be properly reviewed (2 reviews required, with at least 1 reviewer, 1 author)
>> 
>> 
>> And here is the comment:
>> 
>> 
>> The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with 1 of role reviewers, 1 of role authors).
>> 
>> 
>> Both "Reviewer" and "Author" should be capitalized in both messages. Separately, I see that the pluralization was fixed in the Progress item, but not the comment.
>
> There are also projects that do not have any members in the Reviewer role, so they configure their repository to only require Committers. The only role I doubt we will ever see required in reality is Lead, but that's ok.

What about changing the message `(with 1 of role reviewers, 1 of role authors)` to `(with at least 1 Reviewer, 1 Author)` and obeying the same pluralization rule. The message `(with 1 of role reviewers, 1 of role authors)` may be fixed as `(with 1 of role Reviewer, 1 of role Author)`. But if there is a message `(with 2 of role reviewers)`, we don't know whether it should fixed as `(with 2 of role Reviewer)` or `(with 2 of role Reviewers)` (pluralization). It is good to unify it to `(with at least 2 Reviewers)`.

-------------

PR: https://git.openjdk.java.net/skara/pull/1305