RFR: 282: Make the review requirements more explicit in the progress list [v3]

Guoxiong Li gli at openjdk.java.net
Wed May 11 15:27:23 UTC 2022

On Wed, 11 May 2022 14:25:46 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> There are also projects that do not have any members in the Reviewer role, so they configure their repository to only require Committers. The only role I doubt we will ever see required in reality is Lead, but that's ok.
> What about changing the message `(with 1 of role reviewers, 1 of role authors)` to `(with at least 1 Reviewer, 1 Author)` and obeying the same pluralization rule. The message `(with 1 of role reviewers, 1 of role authors)` may be fixed as `(with 1 of role Reviewer, 1 of role Author)`. But if there is a message `(with 2 of role reviewers)`, we don't know whether it should fixed as `(with 2 of role Reviewer)` or `(with 2 of role Reviewers)` (pluralization). It is good to unify it to `(with at least 2 Reviewers)`.

I submitted a PR https://github.com/openjdk/skara/pull/1319. We can continue the discussion there.


PR: https://git.openjdk.java.net/skara/pull/1305

More information about the skara-dev mailing list