RFR: 1437: Fix the OpenJDK official role name and pluralization

Erik Joelsson erikj at openjdk.java.net
Wed May 11 17:09:07 UTC 2022

On Wed, 11 May 2022 15:22:58 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> This patch mainly fixes the following message:
> 1. Remove the pluralization if these is 0 reviewer. `no reviews required` --> `no review required`
> 2. Fix the official role name. eg: `reviewer` --> `Reviewer`, `committers` --> `Committers`
> 3. Unify the comment and the progress message. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)`
> 4. Fix the pluralization of the comment. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)` Note the pluralization.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

Reading your comment in the other PR, it got me thinking, if we really want to make it clear that we are referencing the OpenJDK roles, then perhaps we should make each instance of `Reviewer` or `Author` etc be a link to the section in the bylaws. e.g. 1 [Reviewer](http://openjdk.java.net/bylaws#reviewer), 2 [Authors](http://openjdk.java.net/bylaws#author)


PR: https://git.openjdk.java.net/skara/pull/1319

More information about the skara-dev mailing list