RFR: 1437: Fix the OpenJDK official role name and pluralization [v2]

Guoxiong Li gli at openjdk.java.net
Sat May 14 13:02:39 UTC 2022


On Sat, 14 May 2022 12:46:19 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add bylaws link of the role.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 148:
> 
>> 146:         var nonZeroDescriptions = formatLimits.entrySet().stream()
>> 147:                 .filter(entry -> entry.getValue() > 0)
>> 148:                 .map(entry -> entry.getValue() + " " + String.format(entry.getKey(), entry.getValue() > 1 ? "s" : "", "http://openjdk.java.net/bylaws"))
> 
> This really should use "https" rather than "http".

It is good to fix it at this PR. I am fixing it now.

-------------

PR: https://git.openjdk.java.net/skara/pull/1319


More information about the skara-dev mailing list