RFR: 1437: Fix the OpenJDK official role name and pluralization [v2]

[Kevin Rushforth]

On Thu, 12 May 2022 03:38:44 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch mainly fixes the following message:
>> 
>> 1. Remove the pluralization if these is 0 reviewer. `no reviews required` --> `no review required`
>> 2. Fix the official role name. eg: `reviewer` --> `Reviewer`, `committers` --> `Committers`
>> 3. Unify the comment and the progress message. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)`
>> 4. Fix the pluralization of the comment. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)` Note the pluralization.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add bylaws link of the role.

This looks good to me, although we should use HTTPS (not HTTP) for `openjdk.java.net`. We could do this in a follow-up, or you could change it now before this PR is sponsored.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 148:

> 146:         var nonZeroDescriptions = formatLimits.entrySet().stream()
> 147:                 .filter(entry -> entry.getValue() > 0)
> 148:                 .map(entry -> entry.getValue() + " " + String.format(entry.getKey(), entry.getValue() > 1 ? "s" : "", "http://openjdk.java.net/bylaws"))

This really should use "https" rather than "http".

-------------

PR: https://git.openjdk.java.net/skara/pull/1319