Integrated: 1437: Fix the OpenJDK official role name and pluralization
Guoxiong Li
gli at openjdk.java.net
Wed May 18 12:54:53 UTC 2022
On Wed, 11 May 2022 15:22:58 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> This patch mainly fixes the following message:
>
> 1. Remove the pluralization if these is 0 reviewer. `no reviews required` --> `no review required`
> 2. Fix the official role name. eg: `reviewer` --> `Reviewer`, `committers` --> `Committers`
> 3. Unify the comment and the progress message. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)`
> 4. Fix the pluralization of the comment. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)` Note the pluralization.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
This pull request has now been integrated.
Changeset: 9261f9b6
Author: Guoxiong Li <gli at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/9261f9b6ec9b3a83b427b19fd27c6709d0996982
Stats: 177 lines in 4 files changed: 50 ins; 33 del; 94 mod
1437: Fix the OpenJDK official role name and pluralization
Reviewed-by: erikj, ihse, kcr
-------------
PR: https://git.openjdk.java.net/skara/pull/1319
More information about the skara-dev
mailing list