RFR: 1448: Support specialized suffix pool records for legacy releases

Kevin Rushforth kcr at openjdk.java.net
Wed May 25 15:22:45 UTC 2022

On Wed, 25 May 2022 14:29:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch makes it possible to define specialized "pool" versions with suffixes for 8u in JBS, similar to how it's already possible for 11u+. For example: we could create a JBS `8-pool-foo` version that got consumed by commits with fixVersion `8u331-foo`.

It looks good, although I left a question about one of the if checks.

jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 59:

> 57:                     finalComponents.add(legacyMatcher.group(3));
> 58:                 }
> 59:                 if (legacyMatcher.groupCount() > 3 && legacyMatcher.group(4) != null) {

Should that be `> 4`? if it was equal to 4 wouldn't `group(4)` be OOB?


Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1320

More information about the skara-dev mailing list