RFR: 1448: Support specialized suffix pool records for legacy releases [v2]

[Erik Joelsson]

On Wed, 25 May 2022 15:19:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use >= 4 instead of > 3
>
> jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 59:
> 
>> 57:                     finalComponents.add(legacyMatcher.group(3));
>> 58:                 }
>> 59:                 if (legacyMatcher.groupCount() > 3 && legacyMatcher.group(4) != null) {
> 
> Should that be `> 4`? if it was equal to 4 wouldn't `group(4)` be OOB?

Group 0 is the complete expression and is not included in the count by groupCount(). Perhaps `>= 4` is more readable as the number 4 is the relevant one.

-------------

PR: https://git.openjdk.java.net/skara/pull/1320