Integrated: 1385: Backport MR links to the wrong CSR request

Guoxiong Li gli at openjdk.java.net
Fri May 27 14:37:20 UTC 2022


On Sun, 8 May 2022 13:19:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch solves the wrong CSR in the backport PR. It mainly has the following rules:
> 1. if the `version` in `.jcheck/conf` doesn't exist or the `version` is wrong, the bot think the CSR also doesn't exist.
> 2. else, if the `version` in `.jcheck/conf` matches the fix version of the primary CSR, the bot will use the primary CSR. (primary CSR is the CSR of the primary issue)
> 3. else, if these is a backport issue matches the `version`, the bot will find the CSR of the backport issue. If found, use it. If not, the bot think the CSR doesn't exist.
> 4. else (no backport issue matches the `version`) the bot think the CSR doesn't exist.
> 
> The classes `CSRBot`, `CheckRun` and `CSRCommand` will handle the situations above respectively.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: 9ced76d5
Author:    Guoxiong Li <gli at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/9ced76d50c6830b03b59492d426f2f5032dec828
Stats:     859 lines in 12 files changed: 800 ins; 12 del; 47 mod

1385: Backport MR links to the wrong CSR request

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/skara/pull/1318


More information about the skara-dev mailing list