RFR: 1660: Add confname field to slack log config

Erik Helin ehelin at openjdk.org
Fri Nov 4 13:35:06 UTC 2022

On Wed, 2 Nov 2022 20:40:04 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The Slack log handler currently takes a "username" value as input which if set is sent to Slack as the user name of the message. With modern webhooks, it unfortunately seems that we have lost the feature of overriding the user name of a message. Our current configs put a descriptive string identifying the bot configuration in this field, which we can no longer see.
> I want to add a specific new configuration field to the Slack log handler for the "configname". If set, this will appear first in every Slack message.

Hey Erik, nice work! Just two questions on the patch:

- why keep the field and config value `username`? If modern Slack hooks do not allow a username to be chosen, then shouldn't we remove that property from the config and the corresponding field from `BotSlackHandler`?
- I would probably have used the name `prefix` instead of `configname` for the configuration setting, it is an arbitrary prefix that we just happen to set to the name of the configuration 😄 



PR: https://git.openjdk.org/skara/pull/1413

More information about the skara-dev mailing list