RFR: 1660: Add confname field to slack log config

Erik Joelsson erikj at openjdk.org
Fri Nov 4 13:54:37 UTC 2022

On Fri, 4 Nov 2022 13:31:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hey Erik, nice work! Just two questions on the patch:
> * why keep the field and config value `username`? If modern Slack hooks do not allow a username to be chosen, then shouldn't we remove that property from the config and the corresponding field from `BotSlackHandler`?

I'm not sure if this is a property of all slack webhooks or just the one app we are able to use at the moment. I figured we could leave the code in there for now and just not configure a username. 

> * I would probably have used the name `prefix` instead of `configname` for the configuration setting, it is an arbitrary prefix that we just happen to set to the name of the configuration 😄

That is a good idea. I will change it.


PR: https://git.openjdk.org/skara/pull/1413

More information about the skara-dev mailing list