RFR: 1660: Add confname field to slack log config [v2]

Erik Helin ehelin at openjdk.org
Mon Nov 7 09:20:43 UTC 2022

On Fri, 4 Nov 2022 13:51:17 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > Hey Erik, nice work! Just two questions on the patch:
> > 
> > * why keep the field and config value `username`? If modern Slack hooks do not allow a username to be chosen, then shouldn't we remove that property from the config and the corresponding field from `BotSlackHandler`?
> I'm not sure if this is a property of all slack webhooks or just the one app we are able to use at the moment. I figured we could leave the code in there for now and just not configure a username.

Ok, yeah, lets leave it in for a while.


PR: https://git.openjdk.org/skara/pull/1413

More information about the skara-dev mailing list