RFR: 1673: CSR bot should be able to handle a withdrawn CSR properly

Zhao Song zsong at openjdk.org
Thu Nov 10 19:24:00 UTC 2022

A user reported that skara bot keeps changing the description in his MR.

After investigation, we found a bug related with CSR bot.

The user linked a CSR issue with the main issue, and after that, he found CSR unneeded and withdrawn the CSR issue.

However, our logic about handling withdrawn CSR issue has some problem.

In PullRequestWorkItem#run, the bot would add updateMarker() to the PR body regardless of the state of CSR issue.  And if a PR body contains the updateMarker, it will be updated periodically until the body contains a CSR progress. However, since our CSR issue is withdrawn, the CSR label would not be added to the pr and CSR progress would not be added to the PR body. So it will be an endless loop.

In summary, the bug would happen in such a case, the user withdraw the csr issue before the csr issue bot first time run.

In this patch, before the CSR Issue bot is trying to add the updateMarker, it will check the resolution of the CSR Issue first, if the CSR Issue is already withdrawn, then updateMarker would not be added to the PR body.  And PR bot would work normally.


Commit messages:
 - SKARA-1673

Changes: https://git.openjdk.org/skara/pull/1418/files
 Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1418&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-1673
  Stats: 66 lines in 2 files changed: 65 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1418.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1418/head:pull/1418

PR: https://git.openjdk.org/skara/pull/1418

More information about the skara-dev mailing list