RFR: 1673: CSR bot should be able to handle a withdrawn CSR properly

Erik Joelsson erikj at openjdk.org
Tue Nov 15 20:53:58 UTC 2022

On Thu, 10 Nov 2022 19:20:41 GMT, Zhao Song <zsong at openjdk.org> wrote:

> A user reported that skara bot keeps changing the description in his MR.
> After investigation, we found a bug related with CSR bot.
> The user linked a CSR issue with the main issue, and after that, he found CSR unneeded and withdrawn the CSR issue.
> However, our logic about handling withdrawn CSR issue has some problem.
> In PullRequestWorkItem#run, the bot would add updateMarker() to the PR body regardless of the state of CSR issue.  And if a PR body contains the updateMarker, it will be updated periodically until the body contains a CSR progress. However, since our CSR issue is withdrawn, the CSR label would not be added to the pr and CSR progress would not be added to the PR body. So it will be an endless loop.
> In summary, the bug would happen in such a case, the user withdraw the csr issue before the csr issue bot first time run.
> In this patch, before the CSR Issue bot is trying to add the updateMarker, it will check the resolution of the CSR Issue first, if the CSR Issue is already withdrawn, then updateMarker would not be added to the PR body.  And PR bot would work normally.

Marked as reviewed by erikj (Lead).


PR: https://git.openjdk.org/skara/pull/1418

More information about the skara-dev mailing list